Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: media/midi/midi_manager_usb.cc

Issue 1217853007: Web MIDI: add a new UMA entry for the final result code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #16 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/midi/midi_manager_usb.cc
diff --git a/media/midi/midi_manager_usb.cc b/media/midi/midi_manager_usb.cc
index 3e096d233c7c3b55d3fad89117e92c8c60cb3377..f493b151c884e89cb4f09ab22bbf9781d0a63ae0 100644
--- a/media/midi/midi_manager_usb.cc
+++ b/media/midi/midi_manager_usb.cc
@@ -25,8 +25,7 @@ void MidiManagerUsb::StartInitialization() {
base::Bind(&MidiManager::CompleteInitialization, base::Unretained(this)));
}
-void MidiManagerUsb::Initialize(
- base::Callback<void(MidiResult result)> callback) {
+void MidiManagerUsb::Initialize(base::Callback<void(Result result)> callback) {
initialize_callback_ = callback;
scheduler_.reset(new MidiScheduler(this));
// This is safe because EnumerateDevices cancels the operation on destruction.
@@ -103,18 +102,18 @@ void MidiManagerUsb::OnReceivedData(size_t jack_index,
void MidiManagerUsb::OnEnumerateDevicesDone(bool result,
UsbMidiDevice::Devices* devices) {
if (!result) {
- initialize_callback_.Run(MIDI_INITIALIZATION_ERROR);
+ initialize_callback_.Run(Result::INITIALIZATION_ERROR);
return;
}
input_stream_.reset(new UsbMidiInputStream(this));
devices->swap(devices_);
for (size_t i = 0; i < devices_.size(); ++i) {
if (!AddPorts(devices_[i], static_cast<int>(i))) {
- initialize_callback_.Run(MIDI_INITIALIZATION_ERROR);
+ initialize_callback_.Run(Result::INITIALIZATION_ERROR);
return;
}
}
- initialize_callback_.Run(MIDI_OK);
+ initialize_callback_.Run(Result::OK);
}
bool MidiManagerUsb::AddPorts(UsbMidiDevice* device, int device_id) {

Powered by Google App Engine
This is Rietveld 408576698