Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: media/midi/midi_manager_mac.cc

Issue 1217853007: Web MIDI: add a new UMA entry for the final result code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #16 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/midi/midi_manager_mac.cc
diff --git a/media/midi/midi_manager_mac.cc b/media/midi/midi_manager_mac.cc
index b13b5aa722708cb8066cc52f7808a48781710dda..ade118d2cfd1ab4579fbe055502a27a60c0d15ea 100644
--- a/media/midi/midi_manager_mac.cc
+++ b/media/midi/midi_manager_mac.cc
@@ -161,7 +161,7 @@ void MidiManagerMac::InitializeCoreMIDI() {
MIDIClientCreate(CFSTR("Chrome"), ReceiveMidiNotifyDispatch, this,
&midi_client_);
if (result != noErr || midi_client_ == 0)
- return CompleteInitialization(MIDI_INITIALIZATION_ERROR);
+ return CompleteInitialization(Result::INITIALIZATION_ERROR);
// Create input and output port.
DCHECK_EQ(0u, coremidi_input_);
@@ -172,7 +172,7 @@ void MidiManagerMac::InitializeCoreMIDI() {
this,
&coremidi_input_);
if (result != noErr || coremidi_input_ == 0)
- return CompleteInitialization(MIDI_INITIALIZATION_ERROR);
+ return CompleteInitialization(Result::INITIALIZATION_ERROR);
DCHECK_EQ(0u, coremidi_output_);
result = MIDIOutputPortCreate(
@@ -180,7 +180,7 @@ void MidiManagerMac::InitializeCoreMIDI() {
CFSTR("MIDI Output"),
&coremidi_output_);
if (result != noErr || coremidi_output_ == 0)
- return CompleteInitialization(MIDI_INITIALIZATION_ERROR);
+ return CompleteInitialization(Result::INITIALIZATION_ERROR);
// Following loop may miss some newly attached devices, but such device will
// be captured by ReceiveMidiNotifyDispatch callback.
@@ -224,7 +224,7 @@ void MidiManagerMac::InitializeCoreMIDI() {
// Allocate maximum size of buffer that CoreMIDI can handle.
midi_buffer_.resize(kCoreMIDIMaxPacketListSize);
- CompleteInitialization(MIDI_OK);
+ CompleteInitialization(Result::OK);
}
// static

Powered by Google App Engine
This is Rietveld 408576698