Web MIDI: add a new UMA entry for the final result code

media/midi/midi_manager.cc

Index: media/midi/midi_manager.cc
diff --git a/media/midi/midi_manager.cc b/media/midi/midi_manager.cc
index 4fc5b2364e9da9918d853b6cd657fc5e4e98cd5a..d61bd7a14a3d7e9bb315e3b5daab53140a77a627 100644
--- a/media/midi/midi_manager.cc
+++ b/media/midi/midi_manager.cc
@@ -6,17 +6,20 @@
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/trace_event/trace_event.h"
 
 namespace media {
 namespace midi {
 
 MidiManager::MidiManager()
-    : initialized_(false),
-      result_(MIDI_NOT_SUPPORTED) {
+    : initialized_(false), result_(Result::NOT_INITIALIZED) {
 }
 
 MidiManager::~MidiManager() {
+  UMA_HISTOGRAM_ENUMERATION("Media.Midi.ResultOnShutdown",
+                            static_cast<int>(result_),
+                            static_cast<int>(Result::MAX) + 1);

[Takashi Toyoshima, 2015/07/09 17:43:30]

Hum... presubmit check has a special rule for
UMA_HISTOGRAM_ENUMERATION("Media.*", ...), and it requires "+1" here.

[Alexei Svitkine (slow), 2015/07/09 18:05:27]

Yeah, the media convention is to do it this way, which differs from the rest of
the codebase. I see you updated the enum, so this is fine.

 }
 
 #if !defined(OS_MACOSX) && !defined(OS_WIN) && \
@@ -64,7 +67,7 @@ void MidiManager::StartSession(MidiManagerClient* client) {
     }
     if (too_many_pending_clients_exist) {
       // Return an error immediately if there are too many requests.
-      client->CompleteStartSession(MIDI_INITIALIZATION_ERROR);
+      client->CompleteStartSession(Result::INITIALIZATION_ERROR);
       return;
     }
     // CompleteInitialization() will be called asynchronously when platform
@@ -74,10 +77,10 @@ void MidiManager::StartSession(MidiManagerClient* client) {
 
   // Platform dependent initialization was already finished for previously
   // initialized clients.
-  MidiResult result;
+  Result result;
   {
     base::AutoLock auto_lock(lock_);
-    if (result_ == MIDI_OK) {
+    if (result_ == Result::OK) {
       AddInitialPorts(client);
       clients_.insert(client);
     }
@@ -111,10 +114,10 @@ void MidiManager::DispatchSendMidiData(MidiManagerClient* client,
 }
 
 void MidiManager::StartInitialization() {
-  CompleteInitialization(MIDI_NOT_SUPPORTED);
+  CompleteInitialization(Result::NOT_SUPPORTED);
 }
 
-void MidiManager::CompleteInitialization(MidiResult result) {
+void MidiManager::CompleteInitialization(Result result) {
   DCHECK(session_thread_runner_.get());
   // It is safe to post a task to the IO thread from here because the IO thread
   // should have stopped if the MidiManager is going to be destructed.
@@ -166,7 +169,7 @@ void MidiManager::ReceiveMidiData(
     client->ReceiveMidiData(port_index, data, length, timestamp);
 }
 
-void MidiManager::CompleteInitializationInternal(MidiResult result) {
+void MidiManager::CompleteInitializationInternal(Result result) {
   TRACE_EVENT0("midi", "MidiManager::CompleteInitialization");
 
   base::AutoLock auto_lock(lock_);
@@ -176,7 +179,7 @@ void MidiManager::CompleteInitializationInternal(MidiResult result) {
   result_ = result;
 
   for (auto client : pending_clients_) {
-    if (result_ == MIDI_OK) {
+    if (result_ == Result::OK) {
       AddInitialPorts(client);
       clients_.insert(client);
     }