Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1217853002: Revert of content: Fix single process support for native GpuMemoryBuffers. (Closed)

Created:
5 years, 5 months ago by grt (UTC plus 2)
Modified:
5 years, 5 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, vignatti (out of this project)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content: Fix single process support for native GpuMemoryBuffers. (patchset #1 id:1 of https://codereview.chromium.org/1221473003/) Reason for revert: Speculative revert to see if this is what broke XP Tests (1). Original issue's description: > content: Fix single process support for native GpuMemoryBuffers. > > Also add the startup message filter for CreateGpuMemoryBuffer > messages in single process mode. > > BUG=497559, 504121 > > Committed: https://crrev.com/29ec87df6cef29b9f28dd21d385f16ce99df9ce3 > Cr-Commit-Position: refs/heads/master@{#336495} TBR=piman@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497559, 504121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -30 lines) Patch
M content/gpu/gpu_child_thread.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/gpu/in_process_gpu_thread.cc View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
grt (UTC plus 2)
Created Revert of content: Fix single process support for native GpuMemoryBuffers.
5 years, 5 months ago (2015-06-29 13:52:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217853002/1
5 years, 5 months ago (2015-06-29 13:52:53 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 5 months ago (2015-06-29 13:53:30 UTC) #4
reveman
if you can point me to one of the failures I'll try to help determine ...
5 years, 5 months ago (2015-06-29 15:39:01 UTC) #6
grt (UTC plus 2)
5 years, 5 months ago (2015-06-29 15:41:51 UTC) #7
On 2015/06/29 15:39:01, reveman wrote:
> if you can point me to one of the failures I'll try to help determine if this
> change is related

I don't think it is related, although someone already reverted this change at
r336531 before me.

The failures are here:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29?numbui....
Let me know if the failures ring any bells.

I filed http://crbug.com/505450 to have troopers take a look, since I believe
the problem may be with the bot or other infrastructure.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698