Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 1217833007: Cannot rely on auto-positioned absolutely positioned descendants being marked for layout. (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)
Modified:
5 years, 5 months ago
Reviewers:
leviw_travelin_and_unemployed, rhogan
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cannot rely on auto-positioned absolutely positioned descendants being marked for layout. Instead, figure out if such descendants need layout as part of layoutPositionedObjects(). One test is for the actual facebook regression; the others demonstrate that we have now fixed older regressions, or even things that have never worked. BUG=505386 R=leviw@chromium.org,rhogan@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198101

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
leviw_travelin_and_unemployed
lgtm
5 years, 5 months ago (2015-06-30 21:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217833007/1
5 years, 5 months ago (2015-06-30 21:27:39 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 21:31:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198101

Powered by Google App Engine
This is Rietveld 408576698