Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: runtime/observatory/tests/service/isolate_lifecycle_test.dart

Issue 1217823009: Make VM event streams look like real dart streams. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Polish Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/isolate_lifecycle_test.dart
diff --git a/runtime/observatory/tests/service/isolate_lifecycle_test.dart b/runtime/observatory/tests/service/isolate_lifecycle_test.dart
index 318013706ab094fe287449d40e796c4a9840de83..ced3603a9c9d7f739e23aed69553543ec25ce9c1 100644
--- a/runtime/observatory/tests/service/isolate_lifecycle_test.dart
+++ b/runtime/observatory/tests/service/isolate_lifecycle_test.dart
@@ -54,7 +54,7 @@ var tests = [
(VM vm) async {
// Wait for the testee to start all of the isolates.
if (vm.isolates.length != spawnCount + 1) {
- await processServiceEvents(vm, (event, sub, completer) {
+ await processIsolateEvents(vm, (event, sub, completer) {
if (event.kind == ServiceEvent.kIsolateStart) {
if (vm.isolates.length == spawnCount + 1) {
sub.cancel();
@@ -76,7 +76,7 @@ var tests = [
(VM vm) async {
// Wait for all spawned isolates to hit pause-at-exit.
if (numPaused(vm) != spawnCount) {
- await processServiceEvents(vm, (event, sub, completer) {
+ await processDebugEvents(vm, (event, sub, completer) {
if (event.kind == ServiceEvent.kPauseExit) {
if (numPaused(vm) == spawnCount) {
sub.cancel();
@@ -92,7 +92,7 @@ var tests = [
(VM vm) async {
var resumedReceived = 0;
- var eventsDone = processServiceEvents(vm, (event, sub, completer) {
+ var eventsDone = processIsolateEvents(vm, (event, sub, completer) {
if (event.kind == ServiceEvent.kIsolateExit) {
resumedReceived++;
if (resumedReceived == resumeCount) {

Powered by Google App Engine
This is Rietveld 408576698