Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: runtime/observatory/tests/service/gc_test.dart

Issue 1217823009: Make VM event streams look like real dart streams. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Polish Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/gc_test.dart
diff --git a/runtime/observatory/tests/service/gc_test.dart b/runtime/observatory/tests/service/gc_test.dart
index 9d93b0a2295eaec6d359cf8da531928df38dc506..ac677dd543d9f275edeea72c4109a1981e09c48b 100644
--- a/runtime/observatory/tests/service/gc_test.dart
+++ b/runtime/observatory/tests/service/gc_test.dart
@@ -26,13 +26,16 @@ var tests = [
Completer completer = new Completer();
// Expect at least this many GC events.
int gcCountdown = 3;
- isolate.vm.events.stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kGC) {
+ isolate.vm.getGCEventStream().then((stream) {
+ var subscription;
+ subscription = stream.listen((ServiceEvent event) {
+ assert(event.kind == ServiceEvent.kGC);
print('Received GC event');
if (--gcCountdown == 0) {
+ subscription.cancel();
completer.complete();
}
- }
+ });
});
return completer.future;
},

Powered by Google App Engine
This is Rietveld 408576698