Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: runtime/observatory/lib/service_common.dart

Issue 1217823009: Make VM event streams look like real dart streams. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Polish Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library service_common; 5 library service_common;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:typed_data'; 9 import 'dart:typed_data';
10 10
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 offset += metaSize; 201 offset += metaSize;
202 var data = new ByteData.view( 202 var data = new ByteData.view(
203 bytes.buffer, 203 bytes.buffer,
204 bytes.offsetInBytes + offset, 204 bytes.offsetInBytes + offset,
205 bytes.lengthInBytes - offset); 205 bytes.lengthInBytes - offset);
206 var map = _parseJSON(meta); 206 var map = _parseJSON(meta);
207 if (map == null) { 207 if (map == null) {
208 return; 208 return;
209 } 209 }
210 var event = map['event']; 210 var event = map['event'];
211 postServiceEvent(event, data); 211 var streamId = map['streamId'];
212 postServiceEvent(streamId, event, data);
212 }); 213 });
213 } 214 }
214 215
215 void _onStringMessage(String data) { 216 void _onStringMessage(String data) {
216 var map = _parseJSON(data); 217 var map = _parseJSON(data);
217 if (map == null) { 218 if (map == null) {
218 return; 219 return;
219 } 220 }
220 var event = map['event']; 221 var event = map['event'];
221 if (event != null) { 222 if (event != null) {
222 postServiceEvent(event, null); 223 var streamId = map['streamId'];
224 postServiceEvent(streamId, event, null);
223 return; 225 return;
224 } 226 }
225 227
226 // Extract serial and result. 228 // Extract serial and result.
227 var serial = map['id']; 229 var serial = map['id'];
228 230
229 // Complete request. 231 // Complete request.
230 var request = _pendingRequests.remove(serial); 232 var request = _pendingRequests.remove(serial);
231 if (request == null) { 233 if (request == null) {
232 Logger.root.severe('Received unexpected message: ${map}'); 234 Logger.root.severe('Received unexpected message: ${map}');
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 if (request.method != 'getTagProfile' && 319 if (request.method != 'getTagProfile' &&
318 request.method != 'getIsolateMetric' && 320 request.method != 'getIsolateMetric' &&
319 request.method != 'getVMMetric') { 321 request.method != 'getVMMetric') {
320 Logger.root.info( 322 Logger.root.info(
321 'GET [${serial}] ${request.method}(${request.params}) from ${target.ne tworkAddress}'); 323 'GET [${serial}] ${request.method}(${request.params}) from ${target.ne tworkAddress}');
322 } 324 }
323 // Send message. 325 // Send message.
324 _webSocket.send(message); 326 _webSocket.send(message);
325 } 327 }
326 } 328 }
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/lib/src/app/application.dart » ('j') | runtime/observatory/lib/src/elements/debugger.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698