Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/perf/benchmarks/skpicture_printer.py

Issue 1217823005: Update skpicture_printer code so it can match user_story classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/skpicture_printer.py
diff --git a/tools/perf/benchmarks/skpicture_printer.py b/tools/perf/benchmarks/skpicture_printer.py
index c70c0f5083d3a0b58e6e6f28150b392120fc5985..99ff5842d7c81d10b3815b1f06eb223a17a90ce6 100644
--- a/tools/perf/benchmarks/skpicture_printer.py
+++ b/tools/perf/benchmarks/skpicture_printer.py
@@ -4,21 +4,19 @@
from core import perf_benchmark
+from telemetry import story
from telemetry import benchmark
from telemetry.core import discover
-from telemetry.page import page_set
from measurements import skpicture_printer
-def _MatchPageSetName(page_set_name, page_set_base_dir):
- page_sets = []
- page_sets += discover.DiscoverClasses(page_set_base_dir, page_set_base_dir,
- page_set.PageSet,
- index_by_class_name=True).values()
- for p in page_sets:
- if page_set_name == p.Name():
- return p
+def _MatchPageSetName(story_set_name, story_set_base_dir):
+ story_sets = discover.DiscoverClasses(story_set_base_dir, story_set_base_dir,
+ story.StorySet).values()
+ for s in story_sets:
+ if story_set_name == s.Name():
+ return s
return None
@@ -47,6 +45,6 @@ class SkpicturePrinter(perf_benchmark.PerfBenchmark):
return skpicture_printer.SkpicturePrinter(options.skp_outdir)
def CreateStorySet(self, options):
- page_set_class = _MatchPageSetName(options.page_set_name,
- options.page_set_base_dir)
- return page_set_class()
+ story_set_class = _MatchPageSetName(options.page_set_name,
+ options.page_set_base_dir)
+ return story_set_class()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698