Issue 1217823003: Revert of Use third_party clang on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217823003: Revert of Use third_party clang on Mac. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach

Modified:
5 years, 5 months ago

Reviewers:
Jakob Kummerow, balazs.kilvady, akos.palfi.imgtec, danno, paul.l...

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Use third_party clang on Mac. (patchset #4 id:60001 of https://codereview.chromium.org/1200833013/) Reason for revert: [Sheriff] Breaks mac on the main waterfall (though not on the tryserver): http://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/3925 Original issue's description: > Use third_party clang on Mac. > > BUG= > > Committed: https://crrev.com/57b20413294940476ab2b2e71ed0802aaf8c223f > Cr-Commit-Position: refs/heads/master@{#29343} TBR=danno@chromium.org,jkummerow@chromium.org,paul.lind@imgtec.com,akos.palfi@imgtec.com,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/976e1e5c59ce31c120e82c9c8a90318490a1ee12 Cr-Commit-Position: refs/heads/master@{#29345}

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/standalone.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Use third_party clang on Mac.

5 years, 5 months ago (2015-06-29 13:06:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217823003/1

5 years, 5 months ago (2015-06-29 13:06:17 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-06-29 13:06:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/976e1e5c59ce31c120e82c9c8a90318490a1ee12
Cr-Commit-Position: refs/heads/master@{#29345}