Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1217813013: Fix CodeFlusher::ProcessOptimizedCodeMaps stale fields. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-6
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix CodeFlusher::ProcessOptimizedCodeMaps stale fields. This makes sure that all pointer fields in an entry in the optimized code map are considered weak, not just the code object. If just one field of an entry dies, then the whole entry dies. R=hpayer@chromium.org Committed: https://crrev.com/cd4275aaf1371c2125653ebe80a65d6fef022bd9 Cr-Commit-Position: refs/heads/master@{#29417}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M src/heap/mark-compact.cc View 1 1 chunk +30 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-01 11:53:14 UTC) #1
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1217813013/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1217813013/diff/1/src/heap/mark-compact.cc#newcode958 src/heap/mark-compact.cc:958: Context::cast(code_map->get(i + SharedFunctionInfo::kContextOffset)); move context before code to ...
5 years, 5 months ago (2015-07-01 12:51:38 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1217813013/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1217813013/diff/1/src/heap/mark-compact.cc#newcode958 src/heap/mark-compact.cc:958: Context::cast(code_map->get(i + SharedFunctionInfo::kContextOffset)); On 2015/07/01 12:51:38, Hannes Payer wrote: ...
5 years, 5 months ago (2015-07-01 12:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813013/20001
5 years, 5 months ago (2015-07-01 13:42:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 13:43:40 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 13:44:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd4275aaf1371c2125653ebe80a65d6fef022bd9
Cr-Commit-Position: refs/heads/master@{#29417}

Powered by Google App Engine
This is Rietveld 408576698