Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/heap/heap.h

Issue 1217813012: GC. Delay/avoid entering high promotion mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rename some variables with long names Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index a57a46d85edd6c351bc66be96d192271b6be3578..3ce381d4904a633eccbead5d558abfa5e444ff2b 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1372,6 +1372,10 @@ class Heap {
return PromotedSpaceSizeOfObjects() - old_generation_size_at_last_gc_;
}
+ // Record the fact that we generated some optimized code since the last GC
+ // which will pretenure some previously unpretenured allocation.
+ void RecordDeoptForPretenuring() { gathering_lifetime_feedback_ = 2; }
+
// Update GC statistics that are tracked on the Heap.
void UpdateCumulativeGCStatistics(double duration, double spent_in_mutator,
double marking_time);
@@ -2173,6 +2177,10 @@ class Heap {
static const int kOldSurvivalRateLowThreshold = 10;
bool new_space_high_promotion_mode_active_;
+ // If this is non-zero, then there is hope yet that the optimized code we
+ // have generated will solve our high promotion rate problems, so we don't
+ // need to go into high promotion mode just yet.
+ int gathering_lifetime_feedback_;
int high_survival_rate_period_length_;
intptr_t promoted_objects_size_;
int low_survival_rate_period_length_;
@@ -2239,8 +2247,6 @@ class Heap {
bool IsLowSurvivalRate() { return low_survival_rate_period_length_ > 0; }
- // TODO(hpayer): Allocation site pretenuring may make this method obsolete.
- // Re-visit incremental marking heuristics.
bool IsHighSurvivalRate() { return high_survival_rate_period_length_ > 0; }
void ConfigureInitialOldGenerationSize();
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698