Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1217813012: GC. Delay/avoid entering high promotion mode (Closed)

Created:
5 years, 5 months ago by Erik Corry Chromium.org
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GC. Delay/avoid entering high promotion mode R=hpayer@chromium.org BUG= Committed: https://crrev.com/a5221d0779d0839055c764b88f412a0793d959b3 Cr-Commit-Position: refs/heads/master@{#29429}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove hooks in compiler and use simpler approach #

Total comments: 4

Patch Set 3 : Rename some variables with long names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M src/heap/heap.h View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
Erik Corry Chromium.org
5 years, 5 months ago (2015-07-01 08:40:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813012/1
5 years, 5 months ago (2015-07-01 08:46:35 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-01 09:19:48 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1217813012/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1217813012/diff/1/src/heap/heap.cc#newcode1257 src/heap/heap.cc:1257: if (!deopted) { There is already logic to avoid ...
5 years, 5 months ago (2015-07-01 09:53:20 UTC) #6
Erik Corry Chromium.org
PTAL - simpler approach that doesn't involve the compiler
5 years, 5 months ago (2015-07-01 14:46:40 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813012/20001
5 years, 5 months ago (2015-07-01 15:19:36 UTC) #9
Hannes Payer (out of office)
looking good, just naming nits https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc#newcode2641 src/heap/heap.cc:2641: bool hope_high_promotion_problem_will_fix_itself = funny ...
5 years, 5 months ago (2015-07-01 15:31:31 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813012/40001
5 years, 5 months ago (2015-07-01 15:38:05 UTC) #12
Erik Corry Chromium.org
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc#newcode2641 src/heap/heap.cc:2641: bool hope_high_promotion_problem_will_fix_itself = On 2015/07/01 15:31:31, Hannes Payer wrote: ...
5 years, 5 months ago (2015-07-01 15:38:40 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-01 16:05:51 UTC) #15
Hannes Payer (out of office)
LGTM
5 years, 5 months ago (2015-07-01 17:40:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217813012/40001
5 years, 5 months ago (2015-07-01 17:40:47 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-01 17:42:22 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 17:42:36 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a5221d0779d0839055c764b88f412a0793d959b3
Cr-Commit-Position: refs/heads/master@{#29429}

Powered by Google App Engine
This is Rietveld 408576698