tools/telemetry/telemetry/internal/util/find_dependencies.py - Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/util/find_dependencies.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ethan's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/internal/util/find_dependencies.py

diff --git a/tools/telemetry/telemetry/internal/util/find_dependencies.py b/tools/telemetry/telemetry/internal/util/find_dependencies.py

index ac03be75d24cea628180c3f80fb0e8b0067582df..802f1e5c4a134eb9574741609dac46fc1e95d56a 100644

--- a/tools/telemetry/telemetry/internal/util/find_dependencies.py

+++ b/tools/telemetry/telemetry/internal/util/find_dependencies.py

@@ -79,10 +79,10 @@ def FindPageSetDependencies(base_dir):

path.GetBaseDir = lambda: base_dir

# TODO: Loading the page set will automatically download its Cloud Storage

# deps. This is really expensive, and we don't want to do this by default.

- page_set = test_obj.CreatePageSet(options)

+ story_set = test_obj.CreateStorySet(options)

# Add all of its serving_dirs as dependencies.

- for serving_dir in page_set.serving_dirs:

+ for serving_dir in story_set.serving_dirs:

yield serving_dir