Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: tools/perf/measurements/smoothness_unittest.py

Issue 1217813005: [Telemetry] Modify CreatePageSet to CreateStorySet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ethan's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 5
6 from telemetry.core import wpr_modes 6 from telemetry.core import wpr_modes
7 from telemetry import decorators 7 from telemetry import decorators
8 from telemetry.page import page 8 from telemetry.page import page
9 from telemetry.unittest_util import options_for_unittests 9 from telemetry.unittest_util import options_for_unittests
10 from telemetry.unittest_util import page_test_test_case 10 from telemetry.unittest_util import page_test_test_case
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 sys.stderr.write("Actual category filter filter: %s\n" % 75 sys.stderr.write("Actual category filter filter: %s\n" %
76 repr(actual_synthetic_delay)) 76 repr(actual_synthetic_delay))
77 self.assertEquals(expected_synthetic_delay, actual_synthetic_delay) 77 self.assertEquals(expected_synthetic_delay, actual_synthetic_delay)
78 78
79 def setUp(self): 79 def setUp(self):
80 self._options = options_for_unittests.GetCopy() 80 self._options = options_for_unittests.GetCopy()
81 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF 81 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF
82 82
83 @decorators.Disabled('chromeos') # crbug.com/483212 83 @decorators.Disabled('chromeos') # crbug.com/483212
84 def testSmoothness(self): 84 def testSmoothness(self):
85 ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html') 85 ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html')
86 measurement = smoothness.Smoothness() 86 measurement = smoothness.Smoothness()
87 results = self.RunMeasurement(measurement, ps, options=self._options) 87 results = self.RunMeasurement(measurement, ps, options=self._options)
88 self.assertEquals(0, len(results.failures)) 88 self.assertEquals(0, len(results.failures))
89 89
90 frame_times = results.FindAllPageSpecificValuesNamed('frame_times') 90 frame_times = results.FindAllPageSpecificValuesNamed('frame_times')
91 self.assertEquals(len(frame_times), 1) 91 self.assertEquals(len(frame_times), 1)
92 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0) 92 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0)
93 93
94 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time') 94 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time')
95 self.assertEquals(len(mean_frame_time), 1) 95 self.assertEquals(len(mean_frame_time), 1)
(...skipping 11 matching lines...) Expand all
107 107
108 mean_input_event_latency = results.FindAllPageSpecificValuesNamed( 108 mean_input_event_latency = results.FindAllPageSpecificValuesNamed(
109 'mean_input_event_latency') 109 'mean_input_event_latency')
110 if mean_input_event_latency: 110 if mean_input_event_latency:
111 self.assertEquals(len(mean_input_event_latency), 1) 111 self.assertEquals(len(mean_input_event_latency), 1)
112 self.assertGreater( 112 self.assertGreater(
113 mean_input_event_latency[0].GetRepresentativeNumber(), 0) 113 mean_input_event_latency[0].GetRepresentativeNumber(), 0)
114 114
115 @decorators.Enabled('android') # SurfaceFlinger is android-only 115 @decorators.Enabled('android') # SurfaceFlinger is android-only
116 def testSmoothnessSurfaceFlingerMetricsCalculated(self): 116 def testSmoothnessSurfaceFlingerMetricsCalculated(self):
117 ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html') 117 ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html')
118 measurement = smoothness.Smoothness() 118 measurement = smoothness.Smoothness()
119 results = self.RunMeasurement(measurement, ps, options=self._options) 119 results = self.RunMeasurement(measurement, ps, options=self._options)
120 self.assertEquals(0, len(results.failures)) 120 self.assertEquals(0, len(results.failures))
121 121
122 avg_surface_fps = results.FindAllPageSpecificValuesNamed('avg_surface_fps') 122 avg_surface_fps = results.FindAllPageSpecificValuesNamed('avg_surface_fps')
123 self.assertEquals(1, len(avg_surface_fps)) 123 self.assertEquals(1, len(avg_surface_fps))
124 self.assertGreater(avg_surface_fps[0].GetRepresentativeNumber, 0) 124 self.assertGreater(avg_surface_fps[0].GetRepresentativeNumber, 0)
125 125
126 jank_count = results.FindAllPageSpecificValuesNamed('jank_count') 126 jank_count = results.FindAllPageSpecificValuesNamed('jank_count')
127 self.assertEquals(1, len(jank_count)) 127 self.assertEquals(1, len(jank_count))
128 self.assertGreater(jank_count[0].GetRepresentativeNumber(), -1) 128 self.assertGreater(jank_count[0].GetRepresentativeNumber(), -1)
129 129
130 max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay') 130 max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay')
131 self.assertEquals(1, len(max_frame_delay)) 131 self.assertEquals(1, len(max_frame_delay))
132 self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0) 132 self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0)
133 133
134 frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths') 134 frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths')
135 self.assertEquals(1, len(frame_lengths)) 135 self.assertEquals(1, len(frame_lengths))
136 self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0) 136 self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0)
137 137
138 def testCleanUpTrace(self): 138 def testCleanUpTrace(self):
139 self.TestTracingCleanedUp(smoothness.Smoothness, self._options) 139 self.TestTracingCleanedUp(smoothness.Smoothness, self._options)
OLDNEW
« no previous file with comments | « tools/perf/measurements/skpicture_printer_unittest.py ('k') | tools/perf/measurements/thread_times_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698