[mac] Delete app shortcuts on app uninstall.

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
+#include "base/mac/mac_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/mac/app_mode_common.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/chromium_strings.h"
 #include "skia/ext/skia_utils_mac.h"
@@ skipping 225 matching lines @@
                     selectFile:base::mac::FilePathToNSString(generated_bundle)
       inFileViewerRootedAtPath:nil];
 }
 
 }  // namespace
 
 namespace web_app {
 
 namespace internals {
 
+FilePath GetAppBundleByExtensionId(std::string extension_id) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+  FSRef ref;
+  CFURLRef* kDontWantURL = NULL;

[Avi (use Gerrit), 2013/02/05 00:19:25]

This isn't a constant so don't name it as such.

+  // This matches APP_MODE_APP_BUNDLE_ID in chrome/chrome.gyp.
+  std::string bundleID =
+      base::mac::BaseBundleID() + std::string(".app.") + extension_id;

[Avi (use Gerrit), 2013/02/05 00:19:25]

This isn't Objective-C code. This (and other variable names)
should_be_named_like_this.

[jeremya, 2013/02/05 02:38:14]

Done.

+  CFStringRef bundleIDCF =
+      CFStringCreateWithCString(NULL, bundleID.c_str(), kCFStringEncodingUTF8);

[Avi (use Gerrit), 2013/02/05 00:19:25]

SysUTF8ToCFStringRef. Also, don't leak this string, please.

[jeremya, 2013/02/05 02:38:14]

Done.

+  OSStatus status = LSFindApplicationForInfo(kLSUnknownCreator, bundleIDCF,
+                                             NULL, &ref, kDontWantURL);

[Avi (use Gerrit), 2013/02/05 00:19:25]

I don't understand. Why do you pass NULL for the inName parameter but use a fake
constant (kDontWantURL) for the last?

FSRefs are long obsolete. I'd much rather you get a CFURLRef back and convert it
rather than use an FSRef.

[jeremya, 2013/02/05 02:38:14]

I cargo-culted from chrome_service_application_mac.mm. Fixed :)

[Avi (use Gerrit), 2013/02/05 04:01:40]

Would you be so kind as to fix it there too? :)

[jeremya, 2013/02/05 04:28:52]

I fixed some things there, but it needs an FSRef for LSOpenApplication.

[Avi (use Gerrit), 2013/02/05 05:15:49]

Yeah, that falls under the "no non-deprecated way to do it". Apple's not immune
to that :)

+
+  if (status != noErr)
+    return FilePath();
+  return FilePath(base::mac::PathFromFSRef(ref));

[Avi (use Gerrit), 2013/02/05 00:19:25]

PathFromFSRef... ew. If we have to deal with APIs that use FSRefs then find, but
here we have an option, so let's not use it.

[jeremya, 2013/02/05 02:38:14]

Done.

+}
+
 bool CreatePlatformShortcuts(
     const FilePath& web_app_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
   string16 bundle_id = UTF8ToUTF16(base::mac::BaseBundleID());
   WebAppShortcutCreator shortcut_creator(web_app_path, shortcut_info,
                             bundle_id);
   return shortcut_creator.CreateShortcut();
 }
 
 void DeletePlatformShortcuts(
     const FilePath& web_app_path,
-    const ShellIntegration::ShortcutInfo& shortcut_info) {
-  // TODO(benwells): Implement this when shortcuts / weblings are enabled on
-  // mac.
+    const ShellIntegration::ShortcutInfo& info) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+
+  FilePath bundle_path = GetAppBundleByExtensionId(info.extension_id);
+  file_util::Delete(bundle_path, true);
 }
 
 void UpdatePlatformShortcuts(
     const FilePath& web_app_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   // TODO(benwells): Implement this when shortcuts / weblings are enabled on
   // mac.
 }
 
 }  // namespace internals
 
 }  // namespace web_app