Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1217793002: [tracing] Avoid double-counting blink_gc free stats in memory-infra (Closed)

Created:
5 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), ssid
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Avoid double-counting blink_gc free stats in memory-infra Currently, when dumping blink_gc (Oilpan) memory, both the heap pages and the freelists are scanned. Both of them report free bytes/objects. At current state, this causes a dump of the following form: blink_gc/thread_X/heaps/HeapName blink_gc/thread_X/heaps/HeapName/pages free_size=1M blink_gc/thread_X/heaps/HeapName/buckets free_size=1M which causes the UI to infer the /HeapName has free_size=2M, which is incorrect. This change forces the /HeapName dump to override the free_{size,count} attributes in order to match the HeapName/pages dump. BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197987

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M Source/platform/heap/Heap.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 5 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Primiano Tucci (use gerrit)
5 years, 5 months ago (2015-06-29 11:08:58 UTC) #2
haraken
LGTM https://codereview.chromium.org/1217793002/diff/1/Source/platform/heap/Heap.cpp File Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/1217793002/diff/1/Source/platform/heap/Heap.cpp#newcode283 Source/platform/heap/Heap.cpp:283: // eqauel to the free_size of the sum ...
5 years, 5 months ago (2015-06-29 11:55:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217793002/20001
5 years, 5 months ago (2015-06-29 13:12:38 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 14:13:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197987

Powered by Google App Engine
This is Rietveld 408576698