Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1217783003: Remove a nonexistent file from BUILD.gn to fix Mac GN Build failure (Closed)

Created:
5 years, 5 months ago by nhiroki
Modified:
5 years, 5 months ago
Reviewers:
Shu Chen, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a nonexistent file from BUILD.gn to fix Mac GN Build failure http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/11962 BUG=474828 TBR=shuchen@chromium.org,sky@chromium.org NOTRY=true Committed: https://crrev.com/2091a8ed54fe3609bfe4f88fedeff53f6a3e3020 Cr-Commit-Position: refs/heads/master@{#337166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
nhiroki
5 years, 5 months ago (2015-07-02 03:18:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217783003/1
5 years, 5 months ago (2015-07-02 03:19:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 03:25:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2091a8ed54fe3609bfe4f88fedeff53f6a3e3020 Cr-Commit-Position: refs/heads/master@{#337166}
5 years, 5 months ago (2015-07-02 03:26:11 UTC) #9
Shu Chen
5 years, 5 months ago (2015-07-02 03:30:50 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698