Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217783002: [android] Configure building android with ninja and clang. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[android] Configure building android with ninja and clang. Make clang dir absolute to avoid differences between ninja and make gyp generator. BUG=chromium:502176 LOG=n Committed: https://crrev.com/c4121b28b110840a7a45b6dbd0ab390d06a4c8b7 Cr-Commit-Position: refs/heads/master@{#29341}

Patch Set 1 #

Patch Set 2 : OS independent cwd check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M build/gyp_v8 View 2 chunks +10 lines, -1 line 0 comments Download
M build/standalone.gypi View 1 8 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217783002/1
5 years, 5 months ago (2015-06-29 09:22:28 UTC) #2
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-06-29 09:25:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217783002/20001
5 years, 5 months ago (2015-06-29 09:50:34 UTC) #6
Michael Achenbach
PTAL
5 years, 5 months ago (2015-06-29 09:59:36 UTC) #8
ulan
lgtm
5 years, 5 months ago (2015-06-29 10:00:56 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-29 10:17:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217783002/20001
5 years, 5 months ago (2015-06-29 10:45:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-29 10:47:25 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 10:47:37 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c4121b28b110840a7a45b6dbd0ab390d06a4c8b7
Cr-Commit-Position: refs/heads/master@{#29341}

Powered by Google App Engine
This is Rietveld 408576698