Source/core/inspector/MainThreadDebugger.cpp - Issue 1217773007: [DevTools] Replace reportCompiledScripts with explicit [get]compiledScripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/MainThreadDebugger.cpp

Issue 1217773007: [DevTools] Replace reportCompiledScripts with explicit [get]compiledScripts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/ScriptDebugListener.h » ('j') | Source/core/inspector/V8Debugger.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/MainThreadDebugger.cpp

diff --git a/Source/core/inspector/MainThreadDebugger.cpp b/Source/core/inspector/MainThreadDebugger.cpp

index 0ffe62d81a8c4ff6810e13ca1ae680f11678953b..e102fb484ecec51738d7d49148197ff3b555ffb1 100644

--- a/Source/core/inspector/MainThreadDebugger.cpp

+++ b/Source/core/inspector/MainThreadDebugger.cpp

@@ -115,7 +115,10 @@ void MainThreadDebugger::addListener(ScriptDebugListener* listener, LocalFrame*

debugger()->enable();

m_listenersMap.set(localFrameRoot, listener);

String contextDataSubstring = "," + String::number(contextDebugId) + "]";

- debugger()->reportCompiledScripts(contextDataSubstring, listener);

+ Vector<ScriptDebugListener::ParsedScript> compiledScripts;

+ debugger()->compiledScripts(contextDataSubstring, compiledScripts);

+ for (size_t i = 0; i < compiledScripts.size(); i++)

yurys 2015/07/07 06:44:54 This logic is now duplicated in 2 places. What's t

dgozman 2015/07/07 07:29:47 It's: 1) more straitforward, 2) allows V8Debugger

+ listener->didParseSource(compiledScripts[i]);

}

void MainThreadDebugger::removeListener(ScriptDebugListener* listener, LocalFrame* localFrame)

« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/ScriptDebugListener.h » ('j') | Source/core/inspector/V8Debugger.cpp » ('J')