LayoutTests/media/mediasession/htmlmediaelement-set-session.html - Issue 1217743003: Add stub for assigning media session to media elements

Side by Side Diff: LayoutTests/media/mediasession/htmlmediaelement-set-session.html

Issue 1217743003: Add stub for assigning media session to media elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update expected files with new line numbers Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/media/mediasession/htmlmediaelement-set-session-expected.txt » ('j') | Source/modules/mediasession/HTMLMediaElementMediaSession.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>HTMLMediaElement set session</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 test(function() {

	7 assert_true(!window.internals \|\| window.internals.runtimeFlags.mediaSessio nEnabled,

	8 "Run either manually by passing the MediaSession flag or as part of th e virtual mediasession testsuite.");
	whywhat 2015/07/02 22:04:54 btw, why isn't the feature enabled as 'test' in Ru btw, why isn't the feature enabled as 'test' in RuntimeFeaturesEnabled.in instead of having a virtual testsuite? davve 2015/07/03 08:25:11 The idea was to try out Jochen's suggestion in: h Show quoted text On 2015/07/02 22:04:54, whywhat wrote: > btw, why isn't the feature enabled as 'test' in RuntimeFeaturesEnabled.in > instead of having a virtual testsuite? The idea was to try out Jochen's suggestion in: https://groups.google.com/a/chromium.org/d/msg/blink-dev/gHgdMtlnYOo/DNBOEvk1... The main advantage being that all other layout tests will test the behaviour with the flag _off_, which is what we'll release during the implementation period. Thus, we test what we ship. The main issues I've stumbled into so far is: * The presubmit script doesn't currently allow "empty" (as in all PASS, no warnings) -expected.txt files for testharness.js, tests not even in virtual. We do need those to not fallback to the non-virtual expected files, which will fail during the implementation period. * Extra churn. Ties into the above but we'll get two -expected.txt (one PASS and one FAIL) files where we with status=test would have none. So in the end, it might not be worth it for such a relatively separated feature such as MediaSession. WDYT?
	9 console.warn("dummy log entry to avoid an empty -expected.txt in virtual/" );

	10

	11 var mediaSession = new MediaSession();

	12 assert_true(mediaSession instanceof MediaSession);
	philipj_slow 2015/07/02 20:22:49 I don't think this and the following assert is nee I don't think this and the following assert is needed in this test, they should be covered by other tests and look kind of paranoid in this context. davve 2015/07/03 09:29:19 Done. Show quoted text On 2015/07/02 20:22:49, philipj wrote: > I don't think this and the following assert is needed in this test, they should > be covered by other tests and look kind of paranoid in this context. Done.
	13

	14 var mediaElement = document.createElement('audio');

	15 assert_true(mediaElement instanceof HTMLMediaElement);

	16

	17 mediaElement.session = mediaSession;

	18 assert_equals(mediaElement.session, mediaSession);

	19

	20 assert_throws(new TypeError, function() { mediaElement.session = document; });

	21 assert_throws(new TypeError, function() { mediaElement.session = "string"; });

	22 assert_throws(new TypeError, function() { mediaElement.session = 42; });

	23 assert_equals(mediaElement.session, mediaSession);

	24

	25 mediaElement.session = null;

	26 assert_equals(mediaElement.session, null);

	27 });

	28 </script>

OLD	NEW