LayoutTests/media/mediasession/htmlmediaelement-set-session-expected.txt - Issue 1217743003: Add stub for assigning media session to media elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/mediasession/htmlmediaelement-set-session-expected.txt

Issue 1217743003: Add stub for assigning media session to media elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Re-upload Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/mediasession/htmlmediaelement-set-session.html ('K') | « LayoutTests/media/mediasession/htmlmediaelement-set-session.html ('k') | LayoutTests/virtual/mediasession/media/mediasession/htmlmediaelement-set-session-expected.txt » ('j') | Source/modules/mediasession/HTMLMediaElementMediaSession.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 FAIL HTMLMediaElement set session assert_true: Run either manually by passing th e MediaSession flag or as part of the virtual mediasession testsuite. expected t rue got false
	sof 2015/07/01 15:18:05 is the expected file here intentionally? is the expected file here intentionally? davve 2015/07/01 15:27:54 Yes, but that's not saying the way I've done it is Show quoted text On 2015/07/01 15:18:05, sof wrote: > is the expected file here intentionally? Yes, but that's not saying the way I've done it is optimal. The MediaSession flag is not part of the experimental set so not enabled by default in when running LayoutTests/. (The idea is to test what we ship.) In addition to this, a virtual testsuite enables the MediaSession flag and run the media session tests with other (virtual) expected files. Thus -expected.txt files in media/mediasession will contain fails and -expected.txt files in virtual/mediasession generally contain passes. Does this make sense?
	3 Harness: the test ran to completion.

	4

OLD	NEW