Issue 12177017: Fixed IsSweepingComplete and EnsureSweeperProgress helper functions.

Issue 12177017: Fixed IsSweepingComplete and EnsureSweeperProgress helper functions. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed IsSweepingComplete and EnsureSweeperProgress helper functions. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13596

Patch Set 5 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
M	src/heap.h	View	1 2 3 4	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/incremental-marking.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/spaces.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/spaces.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM if comments are addressed. https://codereview.chromium.org/12177017/diff/5001/src/heap.h File src/heap.h (right): https://codereview.chromium.org/12177017/diff/5001/src/heap.h#newcode1634 src/heap.h:1634: if (mark_compact_collector()->AreSweeperThreadsActivated()) { Can ...

7 years, 10 months ago (2013-02-05 15:00:29 UTC) #2

Hannes Payer (out of office)

7 years, 10 months ago (2013-02-05 15:45:34 UTC) #3

https://codereview.chromium.org/12177017/diff/5001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/12177017/diff/5001/src/heap.h#newcode1634
src/heap.h:1634: if (mark_compact_collector()->AreSweeperThreadsActivated()) {
Done.

Yes we can, I did not want to mix lazy sweeping and parallel/concurrent sweeping
logic.

On 2013/02/05 15:00:29, Michael Starzinger wrote:
> Can we just turn this whole predicate in to ...
> 
> return !mark_compact_collector()->IsParallelSweepingInProgress() &&
>        old_data_space()->IsLazySweepingComplete() &&
>        old_pointer_space()->IsLazySweepingComplete();

https://codereview.chromium.org/12177017/diff/5001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12177017/diff/5001/src/mark-compact.cc#newcod...
src/mark-compact.cc:544: bool MarkCompactCollector::IsSweepingInProgress() {
Done.

I changed it to IsConcurrentSweepingInProgress() since it is relevant in
concurrent sweeping mode. Calling AreSweeperThreadsActivated() is not necessary
since SweeperThread::sweeping_pending() returns false in the case when sweeper
threads are not present.

On 2013/02/05 15:00:29, Michael Starzinger wrote:
> This should be named IsParallelSweepingInProgress() and should subsume
> AweSweeperThreadsActivated().

Expand Messages | Collapse Messages