Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9516)

Unified Diff: chrome/chrome_resources.gyp

Issue 12177010: Generate about:credits page automatically at build time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix ninja Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_credits.html ('k') | tools/licenses.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_resources.gyp
diff --git a/chrome/chrome_resources.gyp b/chrome/chrome_resources.gyp
index 9cc60599dc693c06e2c6ec9a4d36c3aa77dffc16..701c707d289e19525f906912ff322dc471b67f3c 100644
--- a/chrome/chrome_resources.gyp
+++ b/chrome/chrome_resources.gyp
@@ -4,6 +4,7 @@
{
'variables': {
'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
+ 'about_credits_file': '<(SHARED_INTERMEDIATE_DIR)/about_credits.html',
'repack_locales_cmd': ['python', 'tools/build/repack_locales.py'],
},
'targets': [
@@ -98,12 +99,18 @@
# generated headers.
'target_name': 'chrome_resources',
'type': 'none',
+ 'dependencies': [
+ 'about_credits',
+ ],
'actions': [
# Data resources.
{
'action_name': 'browser_resources',
'variables': {
'grit_grd_file': 'browser/browser_resources.grd',
+ 'grit_additional_defines': [
+ '-E', 'about_credits_file=<(about_credits_file)',
+ ],
},
'includes': [ '../build/grit_action.gypi' ],
},
@@ -429,5 +436,31 @@
],
'includes': [ '../build/grit_target.gypi' ],
},
+ {
+ 'target_name': 'about_credits',
+ 'type': 'none',
+ 'actions': [
+ {
+ 'variables': {
+ 'generator_path': '../tools/licenses.py',
+ },
+ 'action_name': 'generate_about_credits',
+ 'inputs': [
+ # TODO(phajdan.jr): make licenses.py print inputs too.
+ '<(generator_path)',
+ ],
+ 'outputs': [
+ '<(about_credits_file)',
+ ],
+ 'hard_dependency': 1,
+ 'action': ['python',
+ '<(generator_path)',
+ 'credits',
+ '<(about_credits_file)',
+ ],
+ 'message': 'Generating about:credits.',
+ },
+ ],
+ },
], # targets
}
« no previous file with comments | « chrome/browser/resources/about_credits.html ('k') | tools/licenses.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698