Issue 12177010: Generate about:credits page automatically at build time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12177010: Generate about:credits page automatically at build time. (Closed)

Created:
7 years, 10 months ago by Paweł Hajdan Jr.

Modified:
7 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Generate about:credits page automatically at build time. This uses tools/licenses.py internally. BUG=160424 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181293

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -13863 lines)			Patch
M	build/grit_action.gypi	View	1 2 3 4	1 chunk	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/about_credits.html	View	1 2 3 4	1 chunk	+0 lines, -13851 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View	1 2 3	3 chunks	+33 lines, -0 lines	0 comments	Download
M	tools/licenses.py	View		3 chunks	+19 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

Please review. The general idea is to get it running (imperfect) for M26, so I'd ...

7 years, 10 months ago (2013-02-04 09:53:23 UTC) #1

lgtm