chrome/browser/printing/print_preview_dialog_controller_unittest.cc - Issue 12177009: Printing selection from context menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller_unittest.cc

Issue 12177009: Printing selection from context menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_dialog_controller_browsertest.cc ('k') | chrome/browser/printing/print_preview_message_handler.h » ('j') | chrome/common/print_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_dialog_controller_unittest.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller_unittest.cc b/chrome/browser/printing/print_preview_dialog_controller_unittest.cc

index f92c6d0bda5d2cb140815f5bcd467b3a86b8d526..54c7946f8dd4ba50459bc2902a6aa43f67c56001 100644

--- a/chrome/browser/printing/print_preview_dialog_controller_unittest.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller_unittest.cc

@@ -47,7 +47,8 @@ TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_GetOrCreatePreviewTab) {

ASSERT_TRUE(tab_controller);

// Get the preview tab for initiator tab.

- printing::PrintViewManager::FromWebContents(initiator_tab)->PrintPreviewNow();

+ printing::PrintViewManager::FromWebContents(initiator_tab)->

+ PrintPreviewNow(false);

WebContents* preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -92,7 +93,7 @@ TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_MultiplePreviewTabs) {

// Create preview tab for |tab_contents_1|

printing::PrintViewManager::FromWebContents(web_contents_1)->

- PrintPreviewNow();

+ PrintPreviewNow(false);

WebContents* preview_tab_1 =

tab_controller->GetOrCreatePreviewTab(web_contents_1);

@@ -101,7 +102,7 @@ TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_MultiplePreviewTabs) {

// Create preview tab for |tab_contents_2|

printing::PrintViewManager::FromWebContents(web_contents_2)->

- PrintPreviewNow();

+ PrintPreviewNow(false);

WebContents* preview_tab_2 =

tab_controller->GetOrCreatePreviewTab(web_contents_2);

@@ -142,7 +143,8 @@ TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_ClearInitiatorTabDetails) {

ASSERT_TRUE(tab_controller);

// Get the preview tab for initiator tab.

- printing::PrintViewManager::FromWebContents(initiator_tab)->PrintPreviewNow();

+ printing::PrintViewManager::FromWebContents(initiator_tab)->

+ PrintPreviewNow(false);

WebContents* preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);