Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1217653003: Revert of [Telemetry] Modify CreatePageSet to CreateStorySet (Closed)

Created:
5 years, 5 months ago by Rick Byers
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, telemetry-reviews_chromium.org, rmistry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Modify CreatePageSet to CreateStorySet (patchset #2 id:20001 of https://codereview.chromium.org/1217813005/) Reason for revert: Speculative revert to attempt to address extreme long-running telemetry jobs. See http://crbug.com/505867 for details. Original issue's description: > [Telemetry] Modify CreatePageSet to CreateStorySet > > BUG=465594 > > Committed: https://crrev.com/8af27d5cf40ebe4590fd5cc65880c9ab8b632ba4 > Cr-Commit-Position: refs/heads/master@{#336713} TBR=eakuefner@chromium.org,aiolos@chromium.org,kbr@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465594, 505867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -88 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_process.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_rasterization.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/memory_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/trace_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 13 chunks +25 lines, -25 lines 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/inbox_benchmark.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/jetstream.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/oilpan_gc_times.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/page_cycler.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/rasterize_and_record_micro.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/session_restore.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/skpicture_printer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/speedometer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/blink_style_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 2 chunks +14 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/find_dependencies.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/record_wpr.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/record_wpr_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Rick Byers
Created Revert of [Telemetry] Modify CreatePageSet to CreateStorySet
5 years, 5 months ago (2015-06-30 18:45:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217653003/1
5 years, 5 months ago (2015-06-30 18:48:16 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 18:50:54 UTC) #4
Failed to apply patch for content/test/gpu/gpu_tests/context_lost.py:
While running git apply --index -3 -p1;
  error: patch failed: content/test/gpu/gpu_tests/context_lost.py:332
  Falling back to three-way merge...
  Applied patch to 'content/test/gpu/gpu_tests/context_lost.py' with conflicts.
  U content/test/gpu/gpu_tests/context_lost.py

Patch:       content/test/gpu/gpu_tests/context_lost.py
Index: content/test/gpu/gpu_tests/context_lost.py
diff --git a/content/test/gpu/gpu_tests/context_lost.py
b/content/test/gpu/gpu_tests/context_lost.py
index
16aaf7d2ff4fc7a31a17e78fe2508c21d573120c..6b8d64b53d778f7042cd62195e1b58f692c57da1
100644
--- a/content/test/gpu/gpu_tests/context_lost.py
+++ b/content/test/gpu/gpu_tests/context_lost.py
@@ -332,7 +332,7 @@
   # For the record, this would have been another way to get the pages
   # to repeat. pageset_repeat would be another option.
   # options = {'page_repeat': 5}
-  def CreateStorySet(self, options):
+  def CreatePageSet(self, options):
     ps = page_set.PageSet(
       base_dir=data_path,
       serving_dirs=set(['']))

Powered by Google App Engine
This is Rietveld 408576698