remoting/webapp/crd/js/host_controller.js - Issue 1217643002: Added HostListApl implementation to connect to legacy directory and GCD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/host_controller.js

Issue 1217643002: Added HostListApl implementation to connect to legacy directory and GCD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcd-e2e

Patch Set: yet another rewrite of host merging logic Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/crd/js/combined_host_list_api.js ('K') | « remoting/webapp/crd/js/combined_host_list_api_unittest.js ('k') | remoting/webapp/crd/js/host_list_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/host_controller.js

diff --git a/remoting/webapp/crd/js/host_controller.js b/remoting/webapp/crd/js/host_controller.js

index a697af316786428231de8a985803e1c85671aade..613396946471ca1a6c624bbc5d211e4e388de721 100644

--- a/remoting/webapp/crd/js/host_controller.js

+++ b/remoting/webapp/crd/js/host_controller.js

@@ -352,7 +352,7 @@ remoting.HostController.prototype.updatePin = function(newPin, onDone,

return;

}

/** @type {string} */

- var hostId = config['host_id'];

+ var hostId = base.getStringAttr(config, 'host_id');

that.hostDaemonFacade_.getPinHash(hostId, newPin).then(

updateDaemonConfigWithHash, remoting.Error.handler(onError));

}