[es6] Function bind should preserve [[Prototype]]

[es6] Function bind should preserve [[Prototype]]

The function returned from Function.prototype.bind should have the same
[[Prototype]] as the receiver.

BUG=v8:3889
LOG=N
R=adamk@chromium.org, verwaest@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/66f5779c5b0d5aafeea3140bc7bc1ad8c7803971
Cr-Commit-Position: refs/heads/master@{#29556}

[arv (Not doing code reviews), 2015-07-01 19:25:10]

PTAL

[adamk, 2015-07-01 19:31:55]

https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-functio...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-functio...
src/runtime/runtime-function.cc:448: Handle<Map> bound_function_map = Map::Copy(
Forcing map creation here seems possibly bad. If you bind the same function over
and over again this'll create a plethora of new maps.

Can you use Map::TransitionToPrototype() here instead?

[arv (Not doing code reviews), 2015-07-01 19:45:17]

Use Map::TransitionToPrototype instead

[arv (Not doing code reviews), 2015-07-01 19:48:36]

Add test for same map

[arv (Not doing code reviews), 2015-07-01 19:51:21]

https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-functio...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-functio...
src/runtime/runtime-function.cc:448: Handle<Map> bound_function_map = Map::Copy(
On 2015/07/01 19:31:55, adamk wrote:
> Forcing map creation here seems possibly bad. If you bind the same function
over
> and over again this'll create a plethora of new maps.
> 
> Can you use Map::TransitionToPrototype() here instead?

Done.

[adamk, 2015-07-01 20:12:41]

lgtm

[arv (Not doing code reviews), 2015-07-07 15:40:15]

The CQ bit was checked by arv@chromium.org to run a CQ dry run

[arv (Not doing code reviews), 2015-07-07 15:40:29]

Toon, can you take a look at this too?

[commit-bot: I haz the power, 2015-07-07 15:40:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217603005/40001

[commit-bot: I haz the power, 2015-07-07 17:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 17:15:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Toon Verwaest, 2015-07-08 16:31:33]

lgtm with comment

https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:449: Handle<Map> bound_function_map =
Map::TransitionToPrototype(
I guess you can avoid this if bound_function_map already has the right
prototype?

[arv (Not doing code reviews), 2015-07-08 16:37:01]

Thanks

https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:449: Handle<Map> bound_function_map =
Map::TransitionToPrototype(
On 2015/07/08 16:31:33, Toon Verwaest wrote:
> I guess you can avoid this if bound_function_map already has the right
> prototype?

Yeah, that should be the common case. I'll check for it.

[arv (Not doing code reviews), 2015-07-09 15:04:47]

Only transition map to prototype if the prototype is not already correct

[arv (Not doing code reviews), 2015-07-09 15:04:58]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-07-09 15:04:59]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1217603005/#ps60001
(title: "Only transition map to prototype if the prototype is not already
correct")

[commit-bot: I haz the power, 2015-07-09 15:05:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217603005/60001

[commit-bot: I haz the power, 2015-07-09 15:48:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-09 15:49:21]

Patchset 4 (id:??) landed as
https://crrev.com/66f5779c5b0d5aafeea3140bc7bc1ad8c7803971
Cr-Commit-Position: refs/heads/master@{#29556}