Issue 12176002: Minor JSON Schema compiler cleanup to remove Property.FromJSON and make

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12176002: Minor JSON Schema compiler cleanup to remove Property.FromJSON and make (Closed)

Created:
7 years, 10 months ago by not at google - send to devlin

Modified:
7 years, 10 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Minor JSON Schema compiler cleanup to remove Property.FromJSON and make Function.returns a type not a property. R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180560

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -56 lines)			Patch
	M	tools/json_schema_compiler/model.py	View		5 chunks	+24 lines, -56 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

When I was refactoring earlier I needed that FromJSON method, I guess the need went ...

7 years, 10 months ago (2013-02-02 00:36:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12176002/1

7 years, 10 months ago (2013-02-02 00:47:15 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-02 01:47:37 UTC) #4

Retried try job too often on win_rel for step(s) chrome_frame_net_tests,
content_browsertests, sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages