Issue 1217593004: Teach Icon to use an AssetBundle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217593004: Teach Icon to use an AssetBundle (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
jackson

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach Icon to use an AssetBundle Currently this asset bundle is based on the network, but soon we'll be able to use a local asset bundle. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b9e5802687eda6faf130c3acd1c08a6cf8863130

Patch Set 1 #

Patch Set 2 : re-upload for bots #

Patch Set 3 : upload again #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -31 lines)			Patch
M	sky/sdk/lib/mojo/asset_bundle.dart	View		2 chunks	+19 lines, -19 lines	0 comments	Download
M	sky/sdk/lib/widgets/basic.dart	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/widgets/icon.dart	View		2 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Yeah, will upload again after landing the previous patch.

5 years, 5 months ago (2015-07-01 21:41:31 UTC) #3

abarth-chromium

5 years, 5 months ago (2015-07-01 22:25:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
b9e5802687eda6faf130c3acd1c08a6cf8863130 (presubmit successful).

Expand Messages | Collapse Messages