Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217573003: Fix all the components to pick the right colours from the theme. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix all the components to pick the right colours from the theme. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4c3cce01570805b13e26ee15a636ffdfd9c921d6

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -166 lines) Patch
M sky/sdk/example/stocks/lib/main.dart View 1 2 chunks +6 lines, -1 line 0 comments Download
M sky/sdk/example/widgets/sector.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/example/widgets/tabs.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/painting/text_style.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/sdk/lib/theme/typography.dart View 1 2 chunks +19 lines, -7 lines 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 2 chunks +6 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 1 3 chunks +14 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu_item.dart View 1 3 chunks +9 lines, -1 line 0 comments Download
M sky/tests/examples/sector-expected.txt View 1 21 chunks +70 lines, -70 lines 0 comments Download
M sky/tests/examples/stocks-expected.txt View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sky/tests/examples/styled_text-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/examples/tabs-expected.txt View 1 2 chunks +22 lines, -22 lines 0 comments Download
M sky/tests/widgets/buttons-expected.txt View 1 3 chunks +9 lines, -9 lines 0 comments Download
M sky/tests/widgets/dialog-expected.txt View 1 1 chunk +14 lines, -14 lines 0 comments Download
M sky/tests/widgets/syncs1-expected.txt View 1 6 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-30 03:24:14 UTC) #2
hansmuller
Please fix example/widgets/tabs.dart, extraBold => FontWeight.w800
5 years, 5 months ago (2015-06-30 14:02:22 UTC) #4
Hixie
On 2015/06/30 at 14:02:22, hansmuller wrote: > Please fix example/widgets/tabs.dart, extraBold => FontWeight.w800 Yeah, this ...
5 years, 5 months ago (2015-06-30 15:26:15 UTC) #5
Hixie
5 years, 5 months ago (2015-06-30 18:50:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4c3cce01570805b13e26ee15a636ffdfd9c921d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698