Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1217563004: Isolate device_unittests. (Closed)

Created:
5 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 5 months ago
Reviewers:
M-A Ruel, rpaquay
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate device_unittests. This is a pretty mechanical change because device_unittests only depends on //base and //device. Just in case USB gadget tests are enabled on the swarming bots usb_gadget.zip is included in device_unittests.isolate. BUG=98637 Committed: https://crrev.com/dffcf17c7f07259f672cbe831dc0039364bd8a14 Cr-Commit-Position: refs/heads/master@{#336908}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -17 lines) Patch
M device/device_tests.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A + device/device_unittests.isolate View 1 2 chunks +4 lines, -17 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 5 months ago (2015-06-27 00:04:12 UTC) #3
Michael Achenbach
I don't feel like an owner of this - just touched some files for a ...
5 years, 5 months ago (2015-06-30 13:30:33 UTC) #4
Reilly Grant (use Gerrit)
M-A, please take a look.
5 years, 5 months ago (2015-06-30 19:46:08 UTC) #6
M-A Ruel
https://codereview.chromium.org/1217563004/diff/1/device/device_unittests.isolate File device/device_unittests.isolate (right): https://codereview.chromium.org/1217563004/diff/1/device/device_unittests.isolate#newcode25 device/device_unittests.isolate:25: 'read_only': 1, Remove, it's not needed anymore. I'll remove ...
5 years, 5 months ago (2015-06-30 19:54:20 UTC) #7
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1217563004/diff/1/device/device_unittests.isolate File device/device_unittests.isolate (right): https://codereview.chromium.org/1217563004/diff/1/device/device_unittests.isolate#newcode25 device/device_unittests.isolate:25: 'read_only': 1, On 2015/06/30 19:54:20, M-A Ruel wrote: > ...
5 years, 5 months ago (2015-06-30 20:38:11 UTC) #8
M-A Ruel
lgtm, thanks!
5 years, 5 months ago (2015-06-30 20:39:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217563004/20001
5 years, 5 months ago (2015-06-30 20:40:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-30 23:13:42 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 23:14:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dffcf17c7f07259f672cbe831dc0039364bd8a14
Cr-Commit-Position: refs/heads/master@{#336908}

Powered by Google App Engine
This is Rietveld 408576698