Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(79)

Issue 1217533003: spec copyedits

Created:
3 years, 8 months ago by Patrice Chalin
Modified:
3 years, 2 months ago
CC:
reviews_dartlang.org, gbracha
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

spec copyedits BNF “syntax errors” found during [automated grammar extraction](https://github.com/chalin/dart-spec-and-grammar). Prose copyedits found during review. BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M docs/language/dartLangSpec.tex View 13 chunks +19 lines, -19 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 8 months ago (2015-07-03 12:31:21 UTC) #2
Lasse Reichstein Nielsen
Just realized that I was set as reviewer here, not Gilad who would is in ...
3 years, 3 months ago (2015-12-18 11:38:22 UTC) #4
gbracha
Mostly ok, but one of these changes is undesirable. See comments. https://codereview.chromium.org/1217533003/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): ...
3 years, 2 months ago (2015-12-21 19:06:54 UTC) #5
Patrice Chalin
3 years, 2 months ago (2015-12-22 05:21:06 UTC) #6
https://codereview.chromium.org/1217533003/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/1217533003/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:1598: \CONST{} D.makeMap(p): w = \CONST{}
\{"help": q\}; // compile-time error
On 2015/12/21 19:06:53, gbracha wrote:
> No, this comes out wrong/  Some of these changes are in fact corrections; some
> are no-ops; but this one is wrong.

I guess that you know that in several other dartCode environments in this spec,
both the single quote character (') and the double quote character (") are used
to enclose strings rather than the use of the LaTeX conventions of `...' and
``...''. E.g.:

L3470: \CONST{} A("x"); // compile-time error
L7100     print("yoyoma");

among others. Either way is fine I suppose, but consistency would be nice. (In
most other language documents I have worked on, the LaTeX string convention is
used in prose and single/double quote characters are used in code environments.)

Powered by Google App Engine
This is Rietveld 408576698