Add RenderObject.childCount

Add RenderObject.childCount

R=ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/d9c04bd0982f28f159b62e2f4942be3f18f7f1f4

[hansmuller, 2015-06-26 17:09:46]

hansmuller@chromium.org changed reviewers:
+ ianh@google.com

[hansmuller, 2015-06-26 17:10:24]

hansmuller@chromium.org changed reviewers:
+ hansmuller@chromium.org

[hansmuller, 2015-06-26 17:10:25]

PTAL

[Hixie, 2015-06-26 17:28:57]

On 2015/06/26 at 17:10:25, hansmuller wrote:
> PTAL

I think this should either be hoisted to the top AbstractNode class, or moved
down to the ContainerParentDataMixin class.

Probably the latter, because there's no point tracking this for classes that can
only have zero or one child, and the Scaffold class (which is the only other
case right now) already has a cheap way to track child count. So probably this
should just be in the ContainerParentDataMixin class.

[hansmuller, 2015-06-26 17:53:27]

On 2015/06/26 17:28:57, Hixie wrote:
> On 2015/06/26 at 17:10:25, hansmuller wrote:
> > PTAL
> 
> I think this should either be hoisted to the top AbstractNode class, or moved
> down to the ContainerParentDataMixin class.
> 
> Probably the latter, because there's no point tracking this for classes that
can
> only have zero or one child, and the Scaffold class (which is the only other
> case right now) already has a cheap way to track child count. So probably this
> should just be in the ContainerParentDataMixin class.

Done.

[Hixie, 2015-06-26 18:04:33]

lgtm

looks fine if you take out those blank lines.

https://codereview.chromium.org/1217533002/diff/20001/sky/sdk/lib/rendering/o...
File sky/sdk/lib/rendering/object.dart (right):

https://codereview.chromium.org/1217533002/diff/20001/sky/sdk/lib/rendering/o...
sky/sdk/lib/rendering/object.dart:400: _childCount += 1;
Since the rest of this function doesn't have paragraph breaks (and indeed, it's
in the same paragraph as the next function and the members defined before it),
it's weird to have newlines here.

https://codereview.chromium.org/1217533002/diff/20001/sky/sdk/lib/rendering/o...
sky/sdk/lib/rendering/object.dart:460: 
ditto here

[hansmuller, 2015-06-26 18:16:10]

https://codereview.chromium.org/1217533002/diff/20001/sky/sdk/lib/rendering/o...
File sky/sdk/lib/rendering/object.dart (right):

https://codereview.chromium.org/1217533002/diff/20001/sky/sdk/lib/rendering/o...
sky/sdk/lib/rendering/object.dart:400: _childCount += 1;
On 2015/06/26 18:04:33, Hixie wrote:
> Since the rest of this function doesn't have paragraph breaks (and indeed,
it's
> in the same paragraph as the next function and the members defined before it),
> it's weird to have newlines here.

Done.

https://codereview.chromium.org/1217533002/diff/20001/sky/sdk/lib/rendering/o...
sky/sdk/lib/rendering/object.dart:460: 
On 2015/06/26 18:04:33, Hixie wrote:
> ditto here

Done.

[hansmuller1, 2015-06-26 18:17:42]

Committed patchset #3 (id:40001) manually as
d9c04bd0982f28f159b62e2f4942be3f18f7f1f4 (presubmit successful).