chrome/browser/resources/pdf/manifest.json - Issue 1217503012: Avoid cross-origin iframe issues when loading PDF in print preview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/manifest.json

Issue 1217503012: Avoid cross-origin iframe issues when loading PDF in print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/index.html ('k') | chrome/browser/resources/pdf/pdf_scripting_api.js » ('j') | content/public/browser/url_data_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/manifest.json

diff --git a/chrome/browser/resources/pdf/manifest.json b/chrome/browser/resources/pdf/manifest.json

index 8c44ec21b43756064f1c5a3bbdcf819e5ee551ad..3a52b816680c8bc12a5b1c1dcad45173a1ac95ea 100644

--- a/chrome/browser/resources/pdf/manifest.json

+++ b/chrome/browser/resources/pdf/manifest.json

@@ -14,18 +14,11 @@

"application/pdf"

"content_security_policy": "script-src 'self' blob: filesystem: chrome://resources; object-src *; plugin-types application/x-google-chrome-pdf",

- // This is to work-around an issue where this extension is not granted

- // permission to access chrome://resources when iframed for print preview.

- // See https://crbug.com/444752.

- "content_scripts": [

- {

- "matches": ["chrome://print/*"],

- "js": ["content_script.js"]

- }

- ],

"mime_types_handler": "<INDEX>",

"web_accessible_resources": [

- "index.html",

- "<INDEX>"

+ "*.js",

+ "*.html",

+ "*.css",

+ "*.png"

]

}

« no previous file with comments | « chrome/browser/resources/pdf/index.html ('k') | chrome/browser/resources/pdf/pdf_scripting_api.js » ('j') | content/public/browser/url_data_source.cc » ('J')