Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5222)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 1217503012: Avoid cross-origin iframe issues when loading PDF in print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
index 352eba5c1d5a92750fbad75a11975d6f83f5a9f3..2d8a7de6e839235359b1ea8b42691a53a0980059 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -363,6 +363,8 @@ content::WebUIDataSource* CreatePrintPreviewUISource() {
source->SetJsonPath("strings.js");
source->AddResourcePath("print_preview.js", IDR_PRINT_PREVIEW_JS);
+ source->AddResourcePath("pdf_preview.html",
+ IDR_PRINT_PREVIEW_PDF_PREVIEW_HTML);
source->AddResourcePath("images/printer.png",
IDR_PRINT_PREVIEW_IMAGES_PRINTER);
source->AddResourcePath("images/printer_shared.png",
@@ -379,6 +381,8 @@ content::WebUIDataSource* CreatePrintPreviewUISource() {
IDR_PRINT_PREVIEW_IMAGES_MOBILE_SHARED);
source->SetDefaultResource(IDR_PRINT_PREVIEW_HTML);
source->SetRequestFilter(base::Bind(&HandleRequestCallback));
+ source->OverrideContentSecurityPolicyFrameSrc("frame-src 'self';");
+ source->DisableDenyXFrameOptions();
source->OverrideContentSecurityPolicyObjectSrc("object-src 'self';");
source->AddLocalizedString("moreOptionsLabel", IDS_MORE_OPTIONS_LABEL);
source->AddLocalizedString("lessOptionsLabel", IDS_LESS_OPTIONS_LABEL);

Powered by Google App Engine
This is Rietveld 408576698