Avoid cross-origin iframe issues when loading PDF in print preview

content/browser/webui/web_ui_data_source_impl.cc

Index: content/browser/webui/web_ui_data_source_impl.cc
diff --git a/content/browser/webui/web_ui_data_source_impl.cc b/content/browser/webui/web_ui_data_source_impl.cc
index ce6b7af4507b839737c7789eaf6fa84ed9024800..d411fe1c828ca44f96faeac8be6e4a5f6e760adf 100644
--- a/content/browser/webui/web_ui_data_source_impl.cc
+++ b/content/browser/webui/web_ui_data_source_impl.cc
@@ -71,6 +71,11 @@ class WebUIDataSourceImpl::InternalDataSource : public URLDataSource {
   bool ShouldDenyXFrameOptions() const override {
     return parent_->deny_xframe_options_;
   }
+  void WillServiceRequest(const net::URLRequest* request,
+                          std::string* path) const override {
+    // We want to remove any query strings from the path.
+    *path = path->substr(0, path->find_last_of('?'));

[Evan Stade, 2015/12/18 23:15:10]

I'm sure someone more knowledgeable than me has already taken a look at this,
but why is find_last_of the right thing? If it's possible to have multiple ?s,
why is

  path.js?q=string?r=strong

being changed into

  path.js?q=string

and not

  path.js

[raymes, 2016/01/04 01:56:18]

Oops good catch. Thank you and I added a test to catch this :)

+  }
 
  private:
   WebUIDataSourceImpl* parent_;