Issue 1217483002: Fix missing source dependencies.

Issue 1217483002: Fix missing source dependencies. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach

Modified:
5 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix missing source dependencies. BUG= Committed: https://crrev.com/3e38d644952e18238937052fb32b14a6a9c85774 Cr-Commit-Position: refs/heads/master@{#29328}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -3 lines)			Patch
M	BUILD.gn	View	1	9 chunks	+19 lines, -0 lines	0 comments	Download
M	src/d8.gyp	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View		9 chunks	+19 lines, -0 lines	0 comments	Download
M	tools/verify_source_deps.py	View		4 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 11 (5 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217483002/40001

5 years, 6 months ago (2015-06-26 13:34:21 UTC) #3

Michael Achenbach

PTAL. There are a few things left after this: GYP: unused simulators + vtune GN: ...

5 years, 6 months ago (2015-06-26 13:35:28 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217483002/40001

5 years, 6 months ago (2015-06-26 13:45:21 UTC) #9

commit-bot: I haz the power

5 years, 6 months ago (2015-06-26 14:25:05 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3e38d644952e18238937052fb32b14a6a9c85774
Cr-Commit-Position: refs/heads/master@{#29328}