AppRTCDemo file logging.

talk/examples/objc/AppRTCDemo/common/ARDLogging.mm

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
  *     this list of conditions and the following disclaimer in the documentation
  *     and/or other materials provided with the distribution.
  *  3. The name of the author may not be used to endorse or promote products
  *     derived from this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
  * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "talk/app/webrtc/dtlsidentityservice.h"
+#import "ARDLogging.h"
 
-#include "talk/app/webrtc/dtlsidentitystore.h"
 #include "webrtc/base/logging.h"
 
-namespace webrtc {
-
-bool DtlsIdentityService::RequestIdentity(
-    const std::string& identity_name,
-    const std::string& common_name,
-    webrtc::DTLSIdentityRequestObserver* observer) {
-  if (identity_name != DtlsIdentityStore::kIdentityName ||
-      common_name != DtlsIdentityStore::kIdentityName) {
-    LOG(LS_WARNING) << "DtlsIdentityService::RequestIdentity called with "
-                    << "unsupported params, identity_name=" << identity_name
-                    << ", common_name=" << common_name;
-    return false;
+void ARDLogToWebRTCLogger(NSString *logString) {

[jiayl2, 2015/07/06 18:18:14]

Add a severity level instead of all LS_INFO? 

[tkchin, 2015/07/06 20:36:50]

How useful is severity level in app context? I feel like it's easier just to use
one macro (ARDLog) and severity because odds are there won't be much app logging
compared to WebRTC spew. If there are app level errors they should be fairly
obvious from the logs without needing to filter.

[jiayl2, 2015/07/06 20:57:56]

It'll make it easier to automatically analyze the log, e.g. listing
errors/warnings from the application.

[tkchin_webrtc, 2015/07/07 23:30:10]

The philosophy on iOS (at least that I've been following) is that we only log
things worthy of warning/error in release builds. In debug builds we have
additional logging through a macro that gets compiled out during release. But
that might just be because there aren't good logging facilities on iOS. Added
severity bits since we get them for free anyway.

+  if (logString.length) {
+#ifndef DEBUG
+    // WebRTC logger doesn't log to console in non-Debug builds by default. Explicitly log to
+    // console in this case.
+    NSLog(@"%@", logString);
+#endif
+    LOG(LS_INFO) << [logString UTF8String];
   }
-  store_->RequestIdentity(observer);
-  return true;
 }
 
-}  // namespace webrtc
+NSString *ARDFileName(const char *filePath) {
+  NSString *nsFilePath = [[NSString alloc] initWithBytesNoCopy:const_cast<char *>(filePath)
+                                                        length:strlen(filePath)
+                                                      encoding:NSUTF8StringEncoding
+                                                  freeWhenDone:NO];
+  return nsFilePath.lastPathComponent;
+}