Issue 1217473004: Make rebuilding faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217473004: Make rebuilding faster (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make rebuilding faster By profiling mine_digger in a continuous rebuild loop, we observe Widget#syncChild as being very hot. This CL optimizes this function by making sure to read each input value exactly once. Also, the hash operations for _mountedChanged were showing up on the profile, so this CL makes _mountedChanged into a List, which should work fine. Together, these changes reduce the amount of time we spend in Navtive code inside the VM from 29% to 20%. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/41b1d24e75e67e2b4dcc931af7a47d7f681a7fbc

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -18 lines)			Patch
	M	sky/sdk/lib/widgets/widget.dart	View		2 chunks	+16 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-06-29 17:20:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41b1d24e75e67e2b4dcc931af7a47d7f681a7fbc (presubmit successful).

Expand Messages | Collapse Messages