Source/modules/credentialmanager/CredentialsContainer.cpp - Issue 1217463002: Remove the notifyFailedSignedIn callback from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 1217463002: Remove the notifyFailedSignedIn callback from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/credentialmanager/CredentialsContainer.h ('k') | Source/modules/credentialmanager/CredentialsContainer.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/credentialmanager/CredentialsContainer.cpp

diff --git a/Source/modules/credentialmanager/CredentialsContainer.cpp b/Source/modules/credentialmanager/CredentialsContainer.cpp

index dc23911f346f7ec6bbbc6b3971ef4ed4b2825d77..c0c18863ccca36bf4da87803e96f27a2dff220c5 100644

--- a/Source/modules/credentialmanager/CredentialsContainer.cpp

+++ b/Source/modules/credentialmanager/CredentialsContainer.cpp

@@ -147,17 +147,6 @@ ScriptPromise CredentialsContainer::notifySignedIn(ScriptState* scriptState, Cre

return promise;

}

-ScriptPromise CredentialsContainer::notifyFailedSignIn(ScriptState* scriptState, Credential* credential)

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

- ScriptPromise promise = resolver->promise();

- if (!checkBoilerplate(resolver))

- return promise;

- CredentialManagerClient::from(scriptState->executionContext())->dispatchFailedSignIn(WebCredential::create(credential->platformCredential()), new NotificationCallbacks(resolver));

- return promise;

ScriptPromise CredentialsContainer::requireUserMediation(ScriptState* scriptState)

{

RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);