Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1217463002: Remove the notifyFailedSignedIn callback from Blink. (Closed)

Created:
4 years, 10 months ago by msramek
Modified:
4 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the notifyFailedSignedIn callback from Blink. As this is not a part of the specification https://w3c.github.io/webappsec/specs/credentialmanagement/#credentialcontainer This patch is a part of a two-sided patchset: Blink: https://codereview.chromium.org/1217463002/ <-- this patch Chromium: https://codereview.chromium.org/1215653003/ BUG=494880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197981

Patch Set 1 : #

Messages

Total messages: 9 (5 generated)
msramek
Hi Mike, I'll continue with the avatar change, but in the meantime, PTAL at another ...
4 years, 10 months ago (2015-06-29 09:16:25 UTC) #5
Mike West
On 2015/06/29 at 09:16:25, msramek wrote: > Hi Mike, > > I'll continue with the ...
4 years, 10 months ago (2015-06-29 09:29:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217463002/60001
4 years, 10 months ago (2015-06-29 09:32:00 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-29 12:00:44 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197981

Powered by Google App Engine
This is Rietveld 408576698