Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1217443004: Android scripts now notify gyp that your building with clang (Closed)

Created:
5 years, 6 months ago by djsollen
Modified:
5 years, 6 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Android scripts now notify gyp that your building with clang Committed: https://skia.googlesource.com/skia/+/4e7956147ddc8fa9747064a1df9ecfa2983b19b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M platform_tools/android/bin/android_setup.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
djsollen
5 years, 6 months ago (2015-06-26 17:41:38 UTC) #2
msarett
lgtm
5 years, 6 months ago (2015-06-26 17:42:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217443004/1
5 years, 6 months ago (2015-06-26 17:52:57 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 18:04:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4e7956147ddc8fa9747064a1df9ecfa2983b19b4

Powered by Google App Engine
This is Rietveld 408576698