Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1217443002: Revert of Re-land new insertion write barrier. (Closed)

Created:
5 years, 6 months ago by Hannes Payer (out of office)
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Re-land new insertion write barrier. (patchset #1 id:1 of https://codereview.chromium.org/1211513002/) Reason for revert: Still crashing in the wild. Original issue's description: > Re-land new insertion write barrier. > > BUG= > > Committed: https://crrev.com/6e6af7e7c70050cdd5ce56cdbaee3b6e8a7caa89 > Cr-Commit-Position: refs/heads/master@{#29258} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/83a41d66748ffd9478a5a0067441c80b7b0e295e Cr-Commit-Position: refs/heads/master@{#29320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M src/heap/incremental-marking-inl.h View 1 chunk +20 lines, -6 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
Created Revert of Re-land new insertion write barrier.
5 years, 6 months ago (2015-06-26 10:52:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217443002/1
5 years, 6 months ago (2015-06-26 10:52:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 10:52:50 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 10:53:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83a41d66748ffd9478a5a0067441c80b7b0e295e
Cr-Commit-Position: refs/heads/master@{#29320}

Powered by Google App Engine
This is Rietveld 408576698