Subzero: Enable errors for unused parameters.

unittest/IceParseInstsTest.cpp

 //===- unittest/IceParseInstsTest.cpp - test instruction errors -----------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include <string>
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/Bitcode/NaCl/NaClBitcodeParser.h"
 #include "llvm/Bitcode/NaCl/NaClLLVMBitCodes.h"
+#pragma clang diagnostic pop
 
 #include "BitcodeMunge.h"
 #include "unittests/Bitcode/NaClMungeTest.h"

[jvoung (off chromium), 2015/06/26 16:11:14]

Btw, this "unittests/..." one is also part of the LLVM repo and could
transitively include LLVM headers

[Jim Stichnoth, 2015/06/27 13:35:33]

Ah, OK.  I actually only applied the pragmas where these warnings were showing
up.  There are several other places that might need the same treatment if the
LLVM headers introduce new instances of the warnings.

 
 using namespace llvm;
 using namespace naclmungetest;
 
 namespace {
 
 // The ParseError constant is passed to the BitcodeMunger to prevent translation
 // when we expect a Parse error.
 constexpr bool ParseError = true;
 
@@ skipping 364 matching lines @@
   EXPECT_EQ("Error(62:4): Invalid function record: <24 2 1 31>\n",
             Munger.getTestResults());
   EXPECT_FALSE(DumpMunger.runTestForAssembly(ARRAY(Align30)));
   EXPECT_EQ(
       "    store float %p1, float* %p0, align 0;\n"
       "Error(62:4): store: Illegal alignment for float. Expects: 1 or 4\n",
       DumpMunger.getLinesWithSubstring("store"));
 }
 
 } // end of anonymous namespace