Subzero: Enable errors for unused parameters.

Subzero: Enable errors for unused parameters.

Uses pragmas when including problematic LLVM headers, so that clang
doesn't warn about unused parameters -- a rampant problem in the LLVM
code.  This way, we can increase clang's pickiness on Subzero code,
and also not drown in LLVM warnings.

BUG= none
R=jpp@chromium.org, jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=98da96678bc2705d4a37e17b87bbb3c031be9ae0

[Jim Stichnoth, 2015-06-26 05:35:59]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, jvoung@chromium.org, kschimpf@google.com

[jvoung (off chromium), 2015-06-26 16:11:14]

LGTM

https://codereview.chromium.org/1217433002/diff/1/unittest/IceParseInstsTest.cpp
File unittest/IceParseInstsTest.cpp (right):

https://codereview.chromium.org/1217433002/diff/1/unittest/IceParseInstsTest....
unittest/IceParseInstsTest.cpp:20: #include "unittests/Bitcode/NaClMungeTest.h"
Btw, this "unittests/..." one is also part of the LLVM repo and could
transitively include LLVM headers

[John, 2015-06-26 17:59:05]

lgtm

This is great! Thanks for doing this.

[Jim Stichnoth, 2015-06-27 13:35:33]

https://codereview.chromium.org/1217433002/diff/1/unittest/IceParseInstsTest.cpp
File unittest/IceParseInstsTest.cpp (right):

https://codereview.chromium.org/1217433002/diff/1/unittest/IceParseInstsTest....
unittest/IceParseInstsTest.cpp:20: #include "unittests/Bitcode/NaClMungeTest.h"
On 2015/06/26 16:11:14, jvoung wrote:
> Btw, this "unittests/..." one is also part of the LLVM repo and could
> transitively include LLVM headers

Ah, OK.  I actually only applied the pragmas where these warnings were showing
up.  There are several other places that might need the same treatment if the
LLVM headers introduce new instances of the warnings.

[Jim Stichnoth, 2015-06-27 13:38:14]

Committed patchset #1 (id:1) manually as
98da96678bc2705d4a37e17b87bbb3c031be9ae0 (tree was closed).