google_apis/gcm/gcm.gyp - Issue 121743002: Renaming RMQStore to GCMStore and breaking out its interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm.gyp

Issue 121743002: Renaming RMQStore to GCMStore and breaking out its interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updates to documentation and test method naming Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/gcm.gyp

diff --git a/google_apis/gcm/gcm.gyp b/google_apis/gcm/gcm.gyp

index f81c4ef449338fc76d8632c011dd1b965fb45bbe..721656a6d931b0e5ba6749876266a1f999e82da0 100644

--- a/google_apis/gcm/gcm.gyp

+++ b/google_apis/gcm/gcm.gyp

@@ -52,10 +52,12 @@

'engine/connection_handler.cc',

'engine/connection_handler_impl.h',

'engine/connection_handler_impl.cc',

+ 'engine/gcm_store.h',

+ 'engine/gcm_store.cc',

Nicolas Zea 2013/12/27 20:03:06 nit: technically the cc should be ordered before t

fgorski 2013/12/27 22:20:39 Done.

+ 'engine/gcm_store_impl.h',

+ 'engine/gcm_store_impl.cc',

'engine/mcs_client.h',

'engine/mcs_client.cc',

- 'engine/rmq_store.h',

- 'engine/rmq_store.cc',

'gcm_client.cc',

'gcm_client.h',

'gcm_client_impl.cc',

@@ -119,7 +121,7 @@

'engine/fake_connection_handler.h',

'engine/fake_connection_handler.cc',

'engine/mcs_client_unittest.cc',

- 'engine/rmq_store_unittest.cc',

+ 'engine/gcm_store_impl_unittest.cc',

]

« google_apis/gcm/engine/mcs_client.h ('K') | « google_apis/gcm/engine/rmq_store_unittest.cc ('k') | google_apis/gcm/tools/mcs_probe.cc » ('j') | no next file with comments »