scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json - Issue 1217403003: Enable ninja_confirm_noop by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json

Issue 1217403003: Enable ninja_confirm_noop by default (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch.json ('k') | scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test_swarming.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json

diff --git a/scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json b/scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json

index c8aed8b12aa6958da04a7071399f7e5b9b3c98b2..d85f2d76fe7442622120577becc2d455b224cdc4 100644

--- a/scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json

+++ b/scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json

@@ -212,6 +212,7 @@

"[BUILD]/goma",

"--goma-fail-fast",

"--goma-disable-local-fallback",

+ "--ninja-ensure-up-to-date",

"--",

"all",

"base_unittests"

@@ -408,6 +409,7 @@

"[BUILD]/goma",

"--goma-fail-fast",

"--goma-disable-local-fallback",

+ "--ninja-ensure-up-to-date",

"--",

"base_unittests"

@@ -485,4 +487,4 @@

"reason": "Step('compile (without patch)') failed with return_code 1",

"status_code": 1

}