Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1217403003: Enable ninja_confirm_noop by default (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json ('k') | scripts/slave/recipes/chromium_trybot_legacy.expected/base_unittests_failure_swarming.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium_trybot.py
diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py
index 741685344a3dc14d0df0e736e09f63d7be627526..97ff91aaf8d03c148971e612f77c3b230c58da65 100644
--- a/scripts/slave/recipes/chromium_trybot.py
+++ b/scripts/slave/recipes/chromium_trybot.py
@@ -430,12 +430,6 @@ def _RunStepsInternal(api):
if enable_gpu_tests:
api.chromium.apply_config('archive_gpu_tests')
- # TODO(phajdan.jr): Make ninja_confirm_noop consistent between main waterfall
- # and trybots, http://crbug.com/501744 .
- if (api.chromium.c.TARGET_PLATFORM != 'android'
- and 'win8' not in buildername):
- api.chromium.apply_config('ninja_confirm_noop')
-
bot_update_step, master_dict, test_spec = \
api.chromium_tests.prepare_checkout(
bot_config['mastername'],
« no previous file with comments | « scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json ('k') | scripts/slave/recipes/chromium_trybot_legacy.expected/base_unittests_failure_swarming.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698